Answer
Yes, there is capital gains tax on shares regardless of whether you are a trader or not.

The rules regarding when you will be deemed a trader are not very clear as it revolves around the issue of intent. If you buy and sell shares in order to generate an income, you will be considered a trader. However, if you make less than eight trades a year, the frequency of your transactions may mean that you are not considered a trader but rather an investor. A good tax advisor will be able to steer you in the right direction.

The question of how long you should hold the shares should not be liked to the desire not to be regarded as a trader. Buying and selling shares is a mix of art and science. Some shares are long term investments, some are speculative. The period of time you should hold the shares depends on the fundamentals of the market and the technical indicators related to that share.

For example, if you purchase a share at R100, and the company you invested in just appointed a new hot shot executive known for increasing profitability in companies that he runs, you might want to hold on to those shares. Alternatively if you bought the same share at the same price and the company reported a severe loss due to mismanagement, you may want to cut your losses and sell.